Review Request 118205: Turn the free space notifier into StatusNotifierItem

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118205/#review58157
-----------------------------------------------------------



freespacenotifier/freespacenotifier.cpp
<https://git.reviewboard.kde.org/r/118205/#comment40428>

    is there no pretty header?



freespacenotifier/freespacenotifier.cpp
<https://git.reviewboard.kde.org/r/118205/#comment40435>

    does this leak now?



freespacenotifier/freespacenotifier.cpp
<https://git.reviewboard.kde.org/r/118205/#comment40434>

    set it to null too
    otherwise you can crash.
    
    Personally I'd also rename to m_ for everything, and consider using a QWeakPointer



freespacenotifier/freespacenotifier.cpp
<https://git.reviewboard.kde.org/r/118205/#comment40432>

    ?



freespacenotifier/freespacenotifier.cpp
<https://git.reviewboard.kde.org/r/118205/#comment40433>

    is it really called this?


- David Edmundson


On May 19, 2014, 2:44 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118205/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 2:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Currently it's done purely as a notification, which doesn't make much sense. This patch turns it into a regular SNI. The actions were moved from the notification popup to the SNI menu.
> 
> 
> Diffs
> -----
> 
>   freespacenotifier/freespacenotifier.h d3c0351 
>   freespacenotifier/freespacenotifier.cpp cdf9bc5 
> 
> Diff: https://git.reviewboard.kde.org/r/118205/diff/
> 
> 
> Testing
> -------
> 
> Works properly.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot (fonts are broken for some reason here)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/19/a918c329-5679-4aeb-9b2e-af260c0bb4d6__fsn_sni.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140519/d3ed5ea0/attachment.html>