Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118206/#review58161
-----------------------------------------------------------



shell/scripting/panel.cpp
<https://git.reviewboard.kde.org/r/118206/#comment40431>

    In this function:
    void Panel::setMaximumLength(int pixels)
    
    You end with calling:
    v->setMinimumLength(pixels);
    
    I don't know the code, but that "looks" like you might be calling the wrong function? I would expect a "v->setMaximumLength(pixels);"


- Mark Gaiser


On May 19, 2014, 3:19 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118206/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 3:19 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> What the title says :).
> 
> 
> Diffs
> -----
> 
>   shell/scripting/panel.h 5b5f971 
>   shell/scripting/panel.cpp b110108 
> 
> Diff: https://git.reviewboard.kde.org/r/118206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140519/c58265e7/attachment-0001.html>