Review Request 118126: Show applets from the system tray in Widget Explorer

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118126/#review58135
-----------------------------------------------------------

Ship it!


Hackish, but needed.


shell/widgetexplorer/widgetexplorer.cpp
<https://git.reviewboard.kde.org/r/118126/#comment40421>

    Maybe this should be compile-time checked, as the code is touched anyway?


- Sebastian Kügler


On May 14, 2014, 1:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118126/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 1:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show applets from the system tray in Widget Explorer
> 
> I'm not super happy with the approach; but I really can't find anything better.
> Registering the Containment in Corona becomes an even bigger hack.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 3121c81 
>   shell/widgetexplorer/widgetexplorer.cpp 1ba8ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/118126/diff/
> 
> 
> Testing
> -------
> 
> Opened widget explorer. 
> 
> Note it seems adding/removing containments whilst the explorer is open is currently unimplemented; this will still be the case for adding/removing the system tray. That can be a different patch.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140519/e359daf3/attachment.html>