Review Request 118198: Fix ToolTipArea.containsMouse not updating when tooltips are disabled globally
Eike Hein
hein at kde.org
Mon May 19 08:24:21 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118198/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Repository: plasma-framework
Description
-------
With the current code, disabling Plasma tooltips globally makes the ToolTipArea.containsMouse not update. That's bad, because ToolTipAreas are often in a position where they're the topmost and critical event handler, since hover events aren't filterable from lower in the item hierarchy. And since there's no API to access the tooltip pref from within QML, there's no way to adapt to this situation either.
This patch changes the implementation so the prop always updates, and the global pref just prevents tooltips from being shown.
Diffs
-----
src/declarativeimports/core/tooltip.h c8ad886
src/declarativeimports/core/tooltip.cpp 2bd0482
Diff: https://git.reviewboard.kde.org/r/118198/diff/
Testing
-------
Thanks,
Eike Hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140519/bd35b303/attachment.html>
More information about the Plasma-devel
mailing list