Review Request 118092: Left and right movement in All music

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092/#review58065
-----------------------------------------------------------



components/listbrowser/ListBrowser.qml
<https://git.reviewboard.kde.org/r/118092/#comment40377>

    A ListBrowser does not need to be in a TabBar, (even though in All Music it is). So as a safeguard, do a check that listBrowserRoot.topSibling.buttons should be defined. Something like-
    var buttons = listBrowserRoot.topSibling.buttons;
    if (buttons) {
        buttons.get(1).button.clicked();
    }
    


- Shantanu Tushar


On May 16, 2014, 3:18 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118092/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 3:18 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 334148
>     http://bugs.kde.org/show_bug.cgi?id=334148
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Left and right movement in All Music -> Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section.
> 
> 
> Diffs
> -----
> 
>   components/listbrowser/ListBrowser.qml 202d406 
> 
> Diff: https://git.reviewboard.kde.org/r/118092/diff/
> 
> 
> Testing
> -------
> 
> 1) Use down arrow key to reach songs.
> 2) Press left/right arrow key.
> 3) Press left/right arrow key(for some reason we have to press the same key twice).
> 4) User reaches Artists if pressed left or Albums if pressed right.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140516/66b274a8/attachment.html>