Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/
-----------------------------------------------------------

(Updated May 16, 2014, 1:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
-------

[screenlocker] Move grace time unlock functionality to KSLDApp

The LockWindow deep called into KSLDApp to unlock in case of user
activity during grace time. But LockWindow also emits a signal on user
activity. From an architectural point of view it's better to handle this
directly in the KSLDApp and connect to the signal to unlock if it's in
grace time.

Another advantage is that LockWindow now no longer pulls in the KSLDApp
which improves the unit test situation for the LockWindow as the
lockWindowTest no longer needs to link the complete ksld library.


Diffs
-----

  ksmserver/screenlocker/autotests/CMakeLists.txt b31bbf79930042af2dfc6c95cedae65bc86655f6 
  ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
  ksmserver/screenlocker/lockwindow.cpp 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 

Diff: https://git.reviewboard.kde.org/r/118160/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140516/a67d3c36/attachment.html>