Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[David Edmundson]

> On May 16, 2014, 12:46 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/lockwindow.cpp, line 307
> > <https://git.reviewboard.kde.org/r/118160/diff/1/?file=273046#file273046line307>
> >
> >     This is a behavioural change as we no longer have the return. 
> >     
> >     Now we'll be indirectly calling unlock() then doing all of this sendEvent() onto a window that I think we've just terminated.
> >     
> >     It might still work but it seems a tad dangerous.
> >     Can you confirm it's ok?
> >     
> >
> 
> Martin Gräßlin wrote:
>     normally it doesn't matter that the events go to a no longer existing window. But anyway: should I change to Qt::QueuedConnection so that the events are processed first and then the unlock kicks in?

Or just move the emit to the end of the function.
Your call.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58055
-----------------------------------------------------------


On May 16, 2014, 7:34 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 7:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140516/6375c359/attachment.html>