Review Request 118148: KRunner: Add the concept of disabled categories

[Vishesh Handa]

> On May 15, 2014, 3:26 p.m., Marco Martin wrote:
> > good feature.
> > I'm just wondering api-wise if would be better to expose the "positive" version of it, enabled categories.
> > That depends i guess on how many categories it's planned to have

Sure. I can change that.

Currently, every runner = 1 category. And some special runners (Baloo and services) have more than 1 category. Considering that we expose "allowedRunners", "allowedCategories" would make more sense. I'll update the review request.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118148/#review58008
-----------------------------------------------------------


On May 15, 2014, 2:37 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118148/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: krunner
> 
> 
> Description
> -------
> 
>     Add the concept of disabled categories
> 
>     Each runner can provide a list of categories which can be used to
>     provide the runner extra information about which categories should be
>     given. This is quite useful when a single runner provides many different
>     categories and not all are required.
> 
>     Additionally, the RunnerManager also disables runners whose categories
>     are disabled.
> 
> 
> Diffs
> -----
> 
>   src/runnercontext.cpp f58bab6 
>   src/runnermanager.h 94d0454 
>   src/runnercontext.h 0fe0038 
>   src/abstractrunner.h d7d13ce 
>   src/abstractrunner.cpp c64c510 
>   src/runnermanager.cpp 75fb9ef 
> 
> Diff: https://git.reviewboard.kde.org/r/118148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140515/64e737c9/attachment.html>