Review Request 118137: Do not overwrite event mask in WindowThumbnailItem

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118137/#review58003
-----------------------------------------------------------

Ship it!


Can't claim I fully understand the patch, but it all kinda makes sense.

- David Edmundson


On May 15, 2014, 6:01 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118137/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 6:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 331956
>     http://bugs.kde.org/show_bug.cgi?id=331956
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Do not overwrite event mask in WindowThumbnailItem
> 
> The WindowThumbnail needs XCB_EVENT_MASK_STRUCTURE_NOTIFY on the window.
> For this it needs to change the window attributes. But it needs to keep
> the existing event mask to not break other code. Also it cannot remove
> the event mask again, as there is no chance to know whether another
> component requires STRUCTURE_NOTIFY.
> 
> This fixes the not updating items in the tasks applet as the event mask
> needed for KWindowSystem got overwritten.
> 
> BUG: 331956
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp c91d1896553f6eecc6828497724d6b119900e40e 
> 
> Diff: https://git.reviewboard.kde.org/r/118137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140515/33a3b817/attachment-0001.html>