Review Request 118145: Plasma-Active: Port the activity switcher

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118145/#review57986
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On May 15, 2014, 12:45 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118145/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 12:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> In this patch i am porting the activity swithcer. Below i am describing the stuff that i have changed.
> 
> *port mobilecomponents to QtQuick 2.2 and KF5
> *move qmlpackages/activityswitcher to activeshellpackage
> *move qmlpackages/contour-tablet-homescreen/contents/ui/ActivityPanel.qml to activeshellpackage.
> *for the activityswithcer i am using the activity components in order to change/delete an activity
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2672295 
>   activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml aa6b362 
>   activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml fc5ff78 
>   activeshellpackage/package/contents/activitymanager/ActivityDelegate.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml 42197fa 
>   activeshellpackage/package/contents/activitymanager/ActivityItem.qml fd22743 
>   activeshellpackage/package/contents/activitymanager/ActivityList.qml 712ca76 
>   activeshellpackage/package/contents/activitymanager/ActivityManager.qml ca10713 
>   activeshellpackage/package/contents/activitymanager/ActivityPanel.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ConfirmationDialog.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ControlButton.qml 1e9854f 
>   activeshellpackage/package/contents/activitymanager/Heading.qml ea0560e 
>   activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml c5dcb98 
>   activeshellpackage/package/contents/activitymanager/ToolBar.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/WindowPreview.qml 295a163 
>   activeshellpackage/package/contents/views/Desktop.qml 67b13cf 
>   components/CMakeLists.txt 0557d13 
>   components/mobilecomponents/ActionButton.qml 53ff260 
>   components/mobilecomponents/CMakeLists.txt 1f57975 
>   components/mobilecomponents/DatePicker.qml e9862b6 
>   components/mobilecomponents/IconButton.qml 1b15305 
>   components/mobilecomponents/IconGrid.qml 881fac1 
>   components/mobilecomponents/OverlayDrawer.qml 9970e16 
>   components/mobilecomponents/Rating.qml 477affd 
>   components/mobilecomponents/ResourceDelegate.qml bdef70d 
>   components/mobilecomponents/SplitDrawer.qml 6bb9c60 
>   components/mobilecomponents/TimePicker.qml 28f9c71 
>   components/mobilecomponents/ViewSearch.qml 9e299b4 
>   components/mobilecomponents/fallbackcomponent.cpp 10fb0a6 
>   components/mobilecomponents/mobilecomponentsplugin.h a7d8010 
>   components/mobilecomponents/mobilecomponentsplugin.cpp db91cad 
>   components/mobilecomponents/package.h 506a0c3 
>   components/mobilecomponents/package.cpp 2412b05 
>   components/mobilecomponents/pagedproxymodel.cpp f861d5b 
>   components/mobilecomponents/private/Digit.qml 173adde 
>   components/mobilecomponents/qmldir 18212b6 
>   components/mobilecomponents/resourcedelegates/Bookmark/Item.qml e653816 
>   components/mobilecomponents/resourcedelegates/Bookmark/ItemHorizontal.qml 84e5e30 
>   components/mobilecomponents/resourcedelegates/FileDataObject/Item.qml 3844b24 
>   components/mobilecomponents/resourcedelegates/FileDataObject/ItemHorizontal.qml ac03b55 
>   components/mobilecomponents/resourcedelegates/Image/Item.qml 0e02c8f 
>   components/mobilecomponents/resourcedelegates/Image/ItemHorizontal.qml 59b7f0c 
>   components/mobilecomponents/texteffects.h 89a438d 
>   components/mobilecomponents/texteffects.cpp f24af9a 
>   components/settings/CMakeLists.txt d21a52d 
>   components/settings/configgroup.h f36511d 
>   components/settings/configgroup.cpp 01e45e3 
>   components/settings/settingscomponent.h 8d52a43 
>   components/settings/settingscomponent.cpp 66a95a9 
>   components/settings/settingsmodulesmodel.h e2aff93 
>   components/settings/settingsmodulesmodel.cpp 6b67398 
>   components/settings/settingsplugin.h fb18863 
>   qmlpackages/CMakeLists.txt 7735195 
>   qmlpackages/activityswitcher/CMakeLists.txt 7bb900e 
>   qmlpackages/activityswitcher/Messages.sh f329d2e 
>   qmlpackages/activityswitcher/contents/images/duplicate.svgz be68aba 
>   qmlpackages/activityswitcher/contents/images/emptyactivity.png 73f2806 
>   qmlpackages/activityswitcher/contents/images/fanstack.svgz 9b82491 
>   qmlpackages/activityswitcher/contents/images/filter.svgz 66e3962 
>   qmlpackages/activityswitcher/contents/images/icons.svgz 54fbbd0 
>   qmlpackages/activityswitcher/contents/images/organize.svgz 2c45e1a 
>   qmlpackages/activityswitcher/contents/images/organize2.svgz 0f9bf66 
>   qmlpackages/activityswitcher/contents/images/plus.svgz 97af277 
>   qmlpackages/activityswitcher/contents/images/slider.png 2ed9860 
>   qmlpackages/activityswitcher/contents/images/slider.svgz 44721e2 
>   qmlpackages/activityswitcher/contents/images/sliderhole.png fcc34d2 
>   qmlpackages/activityswitcher/contents/images/trash.svgz 4e2146b 
>   qmlpackages/activityswitcher/contents/ui/ActivityDelegate.qml 4b68ec9 
>   qmlpackages/activityswitcher/contents/ui/ConfirmationDialog.qml d812316 
>   qmlpackages/activityswitcher/contents/ui/ToolBar.qml 99b6d94 
>   qmlpackages/activityswitcher/contents/ui/config.ui e69de29 
>   qmlpackages/activityswitcher/contents/ui/main.qml d7a6ae1 
>   qmlpackages/activityswitcher/metadata.desktop e585073 
>   qmlpackages/contour-tablet-homescreen/contents/ui/ActivityPanel.qml da3a28a 
> 
> Diff: https://git.reviewboard.kde.org/r/118145/diff/
> 
> 
> Testing
> -------
> 
> Things that they don't work:
> 
> *if you try to delete an activity, the slidding panel is hidding,
> before you are able to delete it.
> *thumbnail can show the wallpaper only if it is not the default one.
> *you cannot create an activity yet
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140515/f121898b/attachment-0001.html>