Review Request 118123: Do not set a custom format on QQuickWindows

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118123/#review57907
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On May 14, 2014, 9:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118123/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 9:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Do not set a custom format on QQuickWindows
> 
> All QQuickWindows share a default format. By setting a custom format
> it overwrites the default and this results in a format without a
> stencil buffer being requested resulting in possible rendering errors.
> 
> This was used to get an alpha buffer. Instead use the static method
> on QQuickWindow to request an alpha buffer.
> 
> 
> Diffs
> -----
> 
>   krunner/main.cpp 279c04839d5c5dbdedda5cb424c54a88f7c85f7c 
>   krunner/view.cpp 9cb398c5dec60a52543fb67de5af21a698553daa 
>   ksmserver/main.cpp baf908bb3d69683407fcfef2d56bdc3023b1f85c 
>   ksmserver/shutdowndlg.cpp 300ffe2d22ccf2b288c50071e97b0d7a02d004c3 
>   ksplash/ksplashqml/SplashWindow.cpp 33fb8ec21e59d255171c11ab74a901a25a7046db 
>   ksplash/ksplashqml/main.cpp 5252baca0642480309c0f6aa59292d0903249905 
>   shell/panelview.cpp 1a6c41f2d960a63f102b554a21eb8f2c545107e2 
> 
> Diff: https://git.reviewboard.kde.org/r/118123/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140514/9530c80d/attachment.html>