Review Request 118122: Do not set a custom format on QQuickWindows

Marco Martin notmart at gmail.com
Wed May 14 10:11:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118122/#review57906
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On May 14, 2014, 9:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118122/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 9:44 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Do not set a custom format on QQuickWindows
> 
> All QQuickWindows share a default format. By setting a custom format
> it overwrites the default and this results in a format without a
> stencil buffer being requested resulting in possible rendering errors.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 86efb1464f88cb625b1ddc21733e07577d1b0c26 
>   src/plasmaquick/view.cpp 6c0ed5447fa9868b7884e9fea6b7820e35733ee0 
> 
> Diff: https://git.reviewboard.kde.org/r/118122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140514/6bfbdc69/attachment.html>


More information about the Plasma-devel mailing list