Review Request 116024: Port IconItem to native QSGTexture

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/
-----------------------------------------------------------

(Updated May 13, 2014, 3:25 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
-------

Port IconItem to native QSGTexture including the animation.
This will save constantly uploading a new texture to OpenGL throughout the animation.


Diffs (updated)
-----

  .reviewboardrc 804529c 
  src/declarativeimports/core/CMakeLists.txt 9b3313d 
  src/declarativeimports/core/fadingnode.cpp PRE-CREATION 
  src/declarativeimports/core/fadingnode_p.h PRE-CREATION 
  src/declarativeimports/core/iconitem.h 92a5233 
  src/declarativeimports/core/iconitem.cpp 9cb487c 

Diff: https://git.reviewboard.kde.org/r/116024/diff/


Testing
-------

Test app: http://paste.kde.org/pl5pwdnel

Test app shows for lots of icons a decrease from 40 -> 27Mb
apitrace has a lot fewer calls to glTexImage2D


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140513/af5b565d/attachment.html>