Review Request 118061: Plasma-mobile: Add an initial shell package

[Marco Martin]

> On May 10, 2014, 12:15 a.m., Aleix Pol Gonzalez wrote:
> > Wouldn't it be better to let the Desktop settle down a bit before we start to fork things out? Actually we should find ways to share code and not having to actually fork these, which is really counter-productive.
> 
> Marco Martin wrote:
>     That's the whole point of having shell packages. One thing that may be improved in the future is introducing a fallback mechanism between packages to not have to copy all, but i'm quite on the fence to that, and i wouldn't do it if not after it has to be provn really, really necessary.
>     And without attempts now I'll never really know for sure what is missing in the whole mechanism.
>     Furthermore, the gsoc on active is *now* and not in a few months time, the mediacenter gscoc is *now* and not in a few months time.
> 
> Aleix Pol Gonzalez wrote:
>     Well, we already have a buggy fork in plasmate. I've seen problems that I've fixed to plasma-shell appearing over there. I don't see why Active is going to be different.
> 
> Aleix Pol Gonzalez wrote:
>     FWIW, we don't need to inherit from different shells, we can actually share code through QML components too.
> 
> Bhushan Shah wrote:
>     Well, I think both plasmate and active/mediacenter cases are totally different.. Plasmoidviewer shares similar code with desktop shell but I don't think active/mediacenter/<any other shell> will share code with the desktop.
> 
> Aleix Pol Gonzalez wrote:
>     Alright, then maybe I'm being overprotective. I understand plasmoidviewer is a special case (although I believe it shouldn't be forking plasma-shell code).
>     
>     Either way, if this is the way it's going to be it would be good to remind how important it is to share code.
>     
>     As for the review, consider my comment discarded.

yep, that's true, it's very important, and thanks for reminding :)
anyways, if sharing is done, i would prefer inheritance instead of components


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118061/#review57664
-----------------------------------------------------------


On May 10, 2014, 4:25 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118061/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 4:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> Add a copy of desktop shell package but remove the stuff that we
> don't need. Like the contextmenu, panelconfiguration and the toolbox
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c7e3797 
>   activeshellpackage/CMakeLists.txt PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityItem.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityList.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ActivityManager.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/ControlButton.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/Heading.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION 
>   activeshellpackage/package/contents/activitymanager/WindowPreview.qml PRE-CREATION 
>   activeshellpackage/package/contents/applet/AppletError.qml PRE-CREATION 
>   activeshellpackage/package/contents/applet/CompactApplet.qml PRE-CREATION 
>   activeshellpackage/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/AppletConfiguration.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION 
>   activeshellpackage/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION 
>   activeshellpackage/package/contents/defaults PRE-CREATION 
>   activeshellpackage/package/contents/explorer/AppletDelegate.qml PRE-CREATION 
>   activeshellpackage/package/contents/explorer/Tooltip.qml PRE-CREATION 
>   activeshellpackage/package/contents/explorer/WidgetExplorer.qml PRE-CREATION 
>   activeshellpackage/package/contents/layout.js PRE-CREATION 
>   activeshellpackage/package/contents/loader.qml PRE-CREATION 
>   activeshellpackage/package/contents/views/Desktop.qml PRE-CREATION 
>   activeshellpackage/package/contents/views/Panel.qml PRE-CREATION 
>   activeshellpackage/package/metadata.desktop PRE-CREATION 
>   qmlpackages/CMakeLists.txt d277441 
> 
> Diff: https://git.reviewboard.kde.org/r/118061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140513/16508b5b/attachment-0001.html>