Review Request 118061: Plasma-mobile: Add an initial shell package

Marco Martin notmart at gmail.com
Sat May 10 09:01:29 UTC 2014



> On May 10, 2014, 12:15 a.m., Aleix Pol Gonzalez wrote:
> > Wouldn't it be better to let the Desktop settle down a bit before we start to fork things out? Actually we should find ways to share code and not having to actually fork these, which is really counter-productive.

That's the whole point of having shell packages. One thing that may be improved in the future is introducing a fallback mechanism between packages to not have to copy all, but i'm quite on the fence to that, and i wouldn't do it if not after it has to be provn really, really necessary.
And without attempts now I'll never really know for sure what is missing in the whole mechanism.
Furthermore, the gsoc on active is *now* and not in a few months time, the mediacenter gscoc is *now* and not in a few months time.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118061/#review57664
-----------------------------------------------------------


On May 9, 2014, 2:05 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118061/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 2:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> Add a copy of desktop shell package but remove the stuff that we
> don't need. Like the contextmenu, panelconfiguration and the toolbox
> 
> 
> Diffs
> -----
> 
>   qmlpackages/shell/package/metadata.desktop PRE-CREATION 
>   qmlpackages/shell/package/contents/views/Panel.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/views/Desktop.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/layout.js PRE-CREATION 
>   qmlpackages/shell/package/contents/loader.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/WidgetExplorer.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/Tooltip.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/AppletDelegate.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/defaults PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/AppletConfiguration.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/CompactApplet.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/AppletError.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/WindowPreview.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/Heading.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ControlButton.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityManager.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityList.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityItem.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION 
>   qmlpackages/shell/CMakeLists.txt PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION 
>   qmlpackages/CMakeLists.txt d277441 
>   CMakeLists.txt c7e3797 
> 
> Diff: https://git.reviewboard.kde.org/r/118061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140510/3540fe70/attachment-0001.html>


More information about the Plasma-devel mailing list