Review Request 117859: rename kioslave files for co-installability

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117859/#review57608
-----------------------------------------------------------


at least to me looks good. only unsure should libmolletnetwork devel symlink, and interface file be installed at all? in 4.x world they come from kde-runtime, which is not used for development purposes...

- Hrvoje Senjan


On April 30, 2014, 11:36 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117859/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> rename kioslave files for co-installability
> 
> ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
> network.xml -> kf5_network.xml
> org.kde.network.kioslavenotifier.xml -> kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I assume something must and will need updated)
> 
> old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/
> 
> 
> Diffs
> -----
> 
>   archive/tar.protocol 9442d4d 
>   bookmarks/bookmarks.protocol 68503d8 
>   cgi/cgi.protocol 862758a 
>   doc/kioslave/bookmarks/CMakeLists.txt d90f510 
>   doc/kioslave/bzip2/CMakeLists.txt 164ff50 
>   doc/kioslave/cgi/CMakeLists.txt 4474a13 
>   doc/kioslave/finger/CMakeLists.txt 54a06b0 
>   doc/kioslave/fish/CMakeLists.txt a711911 
>   doc/kioslave/floppy/CMakeLists.txt 601a7e8 
>   doc/kioslave/gzip/CMakeLists.txt 15d9a61 
>   doc/kioslave/info/CMakeLists.txt 3a4ace9 
>   doc/kioslave/man/CMakeLists.txt 7375332 
>   doc/kioslave/network/CMakeLists.txt 0921d20 
>   doc/kioslave/nfs/CMakeLists.txt 5d98ace 
>   doc/kioslave/sftp/CMakeLists.txt fe08290 
>   doc/kioslave/smb/CMakeLists.txt 906e945 
>   doc/kioslave/tar/CMakeLists.txt a699590 
>   doc/kioslave/thumbnail/CMakeLists.txt 555407d 
>   doc/kioslave/xz/CMakeLists.txt 731d519 
>   filter/bzip.protocol eceae18 
>   filter/bzip2.protocol 3db24ff 
>   filter/gzip.protocol b0fa2b3 
>   filter/lzma.protocol cdaa888 
>   filter/xz.protocol fc66e28 
>   finger/finger.protocol dda641b 
>   fish/fish.protocol fd577c8 
>   floppy/floppy.protocol cbd288a 
>   info/info.protocol c001580 
>   kurifilter-plugins/ikws/CMakeLists.txt 51294b5 
>   kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 
>   man/man.protocol cd03f9f 
>   network/kded/CMakeLists.txt e851f73 
>   network/mimetypes/CMakeLists.txt c20dc90 
>   nfs/nfs.protocol 4781b3c 
>   sftp/sftp.protocol 6e49ed2 
>   smb/smb.protocol e15395e 
>   thumbnail/thumbnail.protocol 216f428 
>   trash/CMakeLists.txt 7c72cdc 
> 
> Diff: https://git.reviewboard.kde.org/r/117859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140508/ad9744c7/attachment.html>