Review Request 117884: rename binaries for co-installability

Jonathan Riddell jr at jriddell.org
Thu May 8 16:17:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117884/
-----------------------------------------------------------

(Updated May 8, 2014, 4:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: kde-cli-tools


Description
-------

these cli tools are in kde-runtime in KDE 4 land so need to be renames so they are co-installable.

Many are unused in the KDE codebase according to lxr but some are used and I'll submit renaming patches to them if this is accepted..
 keditfiletype used by:
  frameworks/kio/src/widgets/kpropertiesdialog.cpp
  frameworks/kwidgetsaddons/src/kmimetypechooser.cpp
  applications/kde-baseapps/lib/konq/konq_operations.cpp
  workspace/plasma-desktop/containments/folder/plugin/internallibkonq/konq_operations.cpp
  workspace/plasma-desktop/kcms/componentchooser/componentchooserfilemanager.cpp
 kmimetypefinder: unused
 ktraderclient: used in
  kde/workspace/kio-extras/kurifilter-plugins/tests/kurifiltertest.cpp
 kioclient: used in
  applications/kde-baseapps/konqueror/client/kfmclient.cpp
  workspace/plasma-workspace/applets/devicenotifier/test-predicate-openinwindow.desktop
  workspace/plasma-workspace/ksmserver/startup.cpp
  workspace/plasma-workspace/drkonqi/data/mappings
 kdecp: unused
 kdemv: unused
 kde-open: unused
 ksvgtopng: unused

I note keditfiletype is used in frameworks so I should also look into moving that into a framework.


Diffs
-----

  keditfiletype/CMakeLists.txt 0adfde946b783cbee09661cfe445792eb1a54649 
  kioclient/CMakeLists.txt cca4f5c222a3266f7ec468fa138bd2cefa880902 
  kmimetypefinder/CMakeLists.txt 720ccb07bd7a0a6a567b3bf70caa00d532232663 
  kstart/CMakeLists.txt e7810d2788290b5f33447f90948dc020e1c8b1b9 
  ksvgtopng/CMakeLists.txt 82602887bb7370e591545b059418a68457c85c28 
  ktraderclient/CMakeLists.txt 028aac3ef9c5e293078df0796ee35577b0679afb 

Diff: https://git.reviewboard.kde.org/r/117884/diff/


Testing
-------


Thanks,

Jonathan Riddell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140508/8491ec57/attachment.html>


More information about the Plasma-devel mailing list