Review Request 118049: Remove useless timer from systray, only closing popup
David Edmundson
david at davidedmundson.co.uk
Thu May 8 11:14:53 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118049/#review57577
-----------------------------------------------------------
Ship it!
That does indeed seem pointless.
In fact this timer would cause a bug if you were to toggle twice within 10ms.
Kill it with fire.
- David Edmundson
On May 8, 2014, 11:05 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118049/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 11:05 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> If it has any actual purpose, there should be a comment.
>
>
> Diffs
> -----
>
> applets/systemtray/package/contents/ui/CompactRepresentation.qml c5c043c
>
> Diff: https://git.reviewboard.kde.org/r/118049/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140508/ec84d6a3/attachment.html>
More information about the Plasma-devel
mailing list