Review Request 117893: Add unit test for kscreenlocker_greet to test all signals

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117893/#review57576
-----------------------------------------------------------


This review has been submitted with commit 7b69bdc753dab1bb9925767ecaa0a6b4473b511a by Martin Gräßlin to branch master.

- Commit Hook


On April 30, 2014, 9:19 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117893/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 9:19 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Wolfgang Bauer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Add unit test for kscreenlocker_greet to test all signals
> 
> The idea behind this unit test is to verify that no matter which signal
> is sent to the greeter it doesn't return an exit code of 0 which would
> indicate a successful authentication.
> 
> The test starts the greeter (needs to be installed) and waits 5 sec to
> make sure that the greeter is really up and running. If the signal is
> sent to early it's causing a CrashExit, which is fine but not the
> expected result. There's an additional test to verify that the early sent
> signal results in CrashExit.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt f7ebde0c576ee41c82f1854190c1f160c47f3229 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140508/a8b14067/attachment.html>