Review Request 118038: Bring back a KCM for the screen locker

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/#review57503
-----------------------------------------------------------


I think this should go into the plasma-desktop repository, under kcms/ (there's already more ksmserver kcm code there).

The spinboxes, I don't find overly useful. Perhaps a combobox with some default values to pick from? (Users that absolutely need per-second granularity for grace and idle times may edit the config file, IMO.)

The name could be improved, see comment below. The Comment, I'm not quite sure about, I don't really like the "configure" bit in there, and it seems kind of heavy (it's used as title at the top). Maybe something like "Timeouts for Screen Locking"? It's clear from the context that it's about "configuration". I'm mulling over the same right now in the new Formats (locale) KCM, btw.

Otherwise, it looks nice and clean to me.


ksmserver/screenlocker/kcm/screenlocker.desktop
<https://git.reviewboard.kde.org/r/118038/#comment40013>

    "Screen Locking", maybe? I think it makes sense to express this in terms of what it does to the user, not which kind of component we're talking about.


- Sebastian Kügler


On May 7, 2014, 3:17 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118038/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 3:17 p.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Bring back a KCM for the screen locker
> 
> Note: I will improve the default values to get them sane. That needs adjustements in the screenlocker source base and I want to get the review of the UI started earlier.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/CMakeLists.txt 3407ea46d5046f2f5b2e7321d714ad1e65ffceea 
>   ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION 
>   ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION 
>   ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118038/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> KCM with values
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
> KCM without values
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140507/e1c02a1d/attachment.html>