Review Request 118017: Fix expansion of ~

Alexander Richardson arichardson.kde at googlemail.com
Wed May 7 14:06:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118017/
-----------------------------------------------------------

(Updated May 7, 2014, 4:06 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and David Faure.


Repository: kio-extras


Description
-------

With QUrl we have to set the scheme manually, seems like KUrl defaulted to
file://.

Also removed the !isMalformed in the codition, QUrl("~") is malformed,
whereas KUrl("~") was not


Diffs
-----

  kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6 

Diff: https://git.reviewboard.kde.org/r/118017/diff/


Testing
-------

Added unit test in KIO, works now


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140507/898fc791/attachment-0001.html>


More information about the Plasma-devel mailing list