Review Request 118017: Fix expansion of ~
David Faure
faure at kde.org
Tue May 6 22:01:13 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118017/#review57458
-----------------------------------------------------------
See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras.
- David Faure
On May 6, 2014, 12:42 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118017/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 12:42 p.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> With QUrl we have to set the scheme manually, seems like KUrl defaulted to
> file://.
>
> Also removed the !isMalformed in the codition, QUrl("~") is malformed,
> whereas KUrl("~") was not
>
>
> Diffs
> -----
>
> kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6
>
> Diff: https://git.reviewboard.kde.org/r/118017/diff/
>
>
> Testing
> -------
>
> Added unit test in KIO, works now
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140506/92bc825c/attachment-0001.html>
More information about the Plasma-devel
mailing list