Review Request 118017: Fix expansion of ~
Alexander Richardson
arichardson.kde at googlemail.com
Tue May 6 12:42:16 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118017/
-----------------------------------------------------------
(Updated May 6, 2014, 2:42 p.m.)
Review request for Plasma and David Faure.
Changes
-------
Added dfaure since he knows a lot about KUrl vs QUrl
Repository: kio-extras
Description
-------
With QUrl we have to set the scheme manually, seems like KUrl defaulted to
file://.
Also removed the !isMalformed in the codition, QUrl("~") is malformed,
whereas KUrl("~") was not
Diffs
-----
kurifilter-plugins/shorturi/kshorturifilter.cpp 58f3435f7599acf692a082d216a0c58684bcf8b6
Diff: https://git.reviewboard.kde.org/r/118017/diff/
Testing
-------
Added unit test in KIO, works now
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140506/e448ecd9/attachment.html>
More information about the Plasma-devel
mailing list