Review Request 117839: [kglobalaccel] Update X11 appTime from key press events

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117839/#review57299
-----------------------------------------------------------

Ship it!


Code looks good.

- Àlex Fiestas


On April 28, 2014, 1:47 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117839/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 1:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [kglobalaccel] Update X11 appTime from key press events
> 
> KGlobalAccelD sends the current appTime through DBus to the application
> and KF5::GlobalAccel updates the appTime from the timestamp. This is
> needed for following actions to succeed. E.g. KWin needs the updated
> appTime for grabbing the keyboard following the kill window shortcut.
> 
> To get the current timestamp we just use the timestamp of the key press
> event delivered to kglobalacceld.
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/kglobalaccel_x11.cpp 454c62e17ac0fb188bbbf2bcefcf42241d7f4ec1 
> 
> Diff: https://git.reviewboard.kde.org/r/117839/diff/
> 
> 
> Testing
> -------
> 
> Tested with ctrl+alt+esc
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140505/1f9de1d7/attachment.html>