Review Request 117822: Add safety checks to XCB functions in WindowThumbnail

Commit Hook null at kde.org
Mon May 5 06:06:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117822/#review57280
-----------------------------------------------------------


This review has been submitted with commit 491befb8508095da3579409a5b81b0d96bb18a06 by Martin Gräßlin to branch master.

- Commit Hook


On April 28, 2014, 8:20 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117822/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 8:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add safety checks to XCB functions in WindowThumbnail
> 
> Prevents XCB warnings about BadWindow when a tooltip is shown for the
> first time.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 
> 
> Diff: https://git.reviewboard.kde.org/r/117822/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140505/9a2b49cf/attachment.html>


More information about the Plasma-devel mailing list