Review Request 117983: Nuke PmcImageProvider and streamline image providers

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117983/
-----------------------------------------------------------

(Updated May 4, 2014, 8:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-mediacenter


Description
-------

The code around fetching/storing covers and other such images from remote sources and local files had become quite confusing over time. This patch removes unnecessary things and moves methods to the right places.


Diffs
-----

  libs/mediacenter/CMakeLists.txt 1072799 
  libs/mediacenter/pmccoverartprovider.h a4aeb83 
  libs/mediacenter/pmccoverartprovider.cpp c68afa2 
  libs/mediacenter/pmcimagecache.h 631d5bd 
  libs/mediacenter/pmcimagecache.cpp d1b57b5 
  libs/mediacenter/pmcimageprovider.h e584810 
  libs/mediacenter/pmcimageprovider.cpp 4198f56 
  libs/mediacenter/pmcmetadatamodel.cpp a58a57b 
  libs/test/lastfmimagefetchertest.cpp b0fcf6f 
  mediaelements/mediaplayer/MusicStats.qml 178a37d 
  mediaelements/popupmenu/PopupMenu.qml 1c87926 
  shells/newshell/mainwindow.cpp 764b228 

Diff: https://git.reviewboard.kde.org/r/117983/diff/


Testing
-------

Tested the following things-
* Album and Artist cover art
* Cover in MusicStats.qml when playing from a file
* Thumbnails in All Videos


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140504/7c453381/attachment.html>