Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117981/#review57227
-----------------------------------------------------------

Ship it!


Few nitpicks, looks okay otherwise.


plugins/kdedesktopsearch/kdemetadatamediasource.cpp
<https://git.reviewboard.kde.org/r/117981/#comment39881>

    const QUrl



plugins/kdedesktopsearch/kdemetadatamediasource.cpp
<https://git.reviewboard.kde.org/r/117981/#comment39880>

    Leftover?


- Shantanu Tushar


On May 4, 2014, 5:22 a.m., Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117981/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 5:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> When "All Pictures" gets opened within PMC, it shows all images indexed by nepomuk. Sometime many images appear which are very small in size and are not useful because those images come from some applications, system icons etc.This patch will filter out images whose width is lesser than 500 pixel.
> 
> 
> Diffs
> -----
> 
>   plugins/kdedesktopsearch/CMakeLists.txt ece8ef2 
>   plugins/kdedesktopsearch/kdemetadatamediasource.h 2d8e7e2 
>   plugins/kdedesktopsearch/kdemetadatamediasource.cpp 94c390a 
> 
> Diff: https://git.reviewboard.kde.org/r/117981/diff/
> 
> 
> Testing
> -------
> 
> Works as expected
> 
> 
> Thanks,
> 
> Sinny Kumari
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140504/d371e48c/attachment.html>