Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117903/
-----------------------------------------------------------

(Updated May 2, 2014, 2:40 p.m.)


Review request for Plasma.


Changes
-------

* created special private slot for the timer-based queued popup display, so it can be separated from the invokable method and that method now does less shenanigans
* changed the method name from "positionPopup" to "displayNotification" as the purpose has changed
  ** forgot to change the name in the qml; done locally now


Repository: plasma-workspace


Description
-------

Before, the notifications would create new Dialog for each incoming notification. Now it reuses only 3 Dialogs to save resources.

The notification popup is a QML component; I decided to handle all this in the cpp plugin as JS Array is quite crap compared to QList and I had quite some crashes in QV4 on slightly heavier Array processing. But as the QML component needs to talk to the dataengine (like when you close the notification or exectue an action) and uses some methods from the rest of the plasmoid, I can't just instantiate it from the cpp side. So I create the component in QML, pass it to CPP, set the ownership to CPP so it's not deleted ever and then handle it all there.


Diffs (updated)
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml 9265352 
  applets/notifications/package/contents/ui/Notifications.qml 64d80a7 
  applets/notifications/plugin/notificationshelper.h 1e1f6c2 
  applets/notifications/plugin/notificationshelper.cpp 1edfbad 

Diff: https://git.reviewboard.kde.org/r/117903/diff/


Testing
-------

Plasma no more leaks memory with every notification (the root memleak, coming from Dialog, is quite possibly still present, but the notifications don't expose it anymore). Notifications work as before, even better.

For testing purposes, you can try running 

for i in {1..10}; do notify-send asasd$i -i kde; done


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140502/bbd2fa67/attachment.html>