Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/#review57102
-----------------------------------------------------------

Ship it!


Looks fine from a Baloo point of view. I cannot comment on the PMC parts, I don't know the code.


plugins/baloosearch/audiosearchresulthandler.cpp
<https://git.reviewboard.kde.org/r/117915/#comment39793>

    Considering that you're checking if the title is empty, do you want to do the same for the Artist and Album?



plugins/baloosearch/searchresulthandler.cpp
<https://git.reviewboard.kde.org/r/117915/#comment39794>

    Please keep in mind that this is sync, and you'll be blocking. You want to put it another thread via the Runnable if you want it to be async.


- Vishesh Handa


On May 1, 2014, 6:06 a.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117915/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 6:06 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Just like the Nepomuk media source, the Baloo media source needs to provide the date/time information for media. This is used to sort the media to show the more recent media first.
> For images, the date/time when the photo was actually taken is used, and the file creation date/time is used for other media.
> 
> 
> Diffs
> -----
> 
>   plugins/baloosearch/CMakeLists.txt 1ff81fb 
>   plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/baloosearchmediasource.h e315de4 
>   plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
>   plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
>   plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117915/diff/
> 
> 
> Testing
> -------
> 
> Tested with all three types of media, works fine. Unit tests for the new code to follow.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140502/2912e031/attachment.html>