Review Request 117801: Make PMC MPRIS compatible

Shantanu Tushar shantanu at kde.org
Thu May 1 08:34:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801/#review57048
-----------------------------------------------------------

Ship it!


looks good now. Please make sure to run mpristester once more before pushing to master.

- Shantanu Tushar


On April 27, 2014, 7:12 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117801/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 7:12 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications.
> http://specifications.freedesktop.org/mpris-spec/latest/index.html
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/CMakeLists.txt 37769f6 
>   libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION 
>   libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION 
>   libs/mediacenter/mpris2/mpris2.h PRE-CREATION 
>   libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.h 9cbf77c 
>   shells/newshell/mainwindow.cpp c1be61a 
>   shells/newshell/package/contents/ui/mediacenter.qml 50f3576 
> 
> Diff: https://git.reviewboard.kde.org/r/117801/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140501/f858ee91/attachment-0001.html>


More information about the Plasma-devel mailing list