Review Request 117923: Export everything by defult for test in plasmamediacentertest librray
Sinny Kumari
ksinny at gmail.com
Thu May 1 06:41:18 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117923/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-mediacenter
Description
-------
Currently test is getting compiled along with libs. Due to this same source was compiled multiple times. With this patch, Plasma-medacenter creates a new plasmamediacentertest library which has default all exported symbols from libs. Now, test can be linked with libplasmamediacentertest.
Diffs
-----
libs/CMakeLists.txt a0a0f72
libs/mediacenter/CMakeLists.txt 2dbec83
libs/mediacenter/test/fakemediavalidator.h 201973c
libs/mediacenter/test/fakemediavalidator.cpp 9b2feca
libs/mediacenter/test/lastfmimagefetchertest.h 6422824
libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f
libs/mediacenter/test/mediacentertest.h 6997ae9
libs/mediacenter/test/mediacentertest.cpp 96a70a9
libs/mediacenter/test/medialibrarytest.h 718457d
libs/mediacenter/test/medialibrarytest.cpp 08af239
libs/mediacenter/test/mediatest.h da16e59
libs/mediacenter/test/mediatest.cpp 832fedb
libs/mediacenter/test/pmcmediatest.h 2322176
libs/mediacenter/test/pmcmediatest.cpp 0da8dd3
libs/mediacenter/test/singletonfactorytest.h 79e4197
libs/mediacenter/test/singletonfactorytest.cpp 308487d
libs/mediacenter/test/testhelpers.h 9825e85
libs/test/fakemediavalidator.h PRE-CREATION
libs/test/fakemediavalidator.cpp PRE-CREATION
libs/test/lastfmimagefetchertest.h PRE-CREATION
libs/test/lastfmimagefetchertest.cpp PRE-CREATION
libs/test/mediacentertest.h PRE-CREATION
libs/test/mediacentertest.cpp PRE-CREATION
libs/test/medialibrarytest.h PRE-CREATION
libs/test/medialibrarytest.cpp PRE-CREATION
libs/test/mediatest.h PRE-CREATION
libs/test/mediatest.cpp PRE-CREATION
libs/test/pmcmediatest.h PRE-CREATION
libs/test/pmcmediatest.cpp PRE-CREATION
libs/test/singletonfactorytest.h PRE-CREATION
libs/test/singletonfactorytest.cpp PRE-CREATION
libs/test/testhelpers.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117923/diff/
Testing
-------
Application runs as expected and all unit test passed
Thanks,
Sinny Kumari
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140501/2ea47a57/attachment-0001.html>
More information about the Plasma-devel
mailing list