Review Request 117121: Add property to determine if popups should be inside or outside the parentItem

[David Edmundson]

> On March 27, 2014, 5:57 p.m., Marco Martin wrote:
> > "break" as in.. ?
> 
> David Edmundson wrote:
>     Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken.
> 
> Marco Martin wrote:
>     uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png
> 
> Marco Martin wrote:
>     ah, no, apparently depends from where the applet is
> 
> Marco Martin wrote:
>     well, i don't see where locateinsideparent should be true.
>     
>     right now locateinsideparent = true if the window is a desktop.. and that doesn't seem to make any sense?
>     
>     if i remove completely locateinsideparent everything seems to just work?

Without ever setting it to true WidgetExplorer won't work when loaded on a second screen which is to the right of the main screen.

We would try to position it to the left outside the parentItem (which is the entire screen) so it appears on the wrong screen. 
The fact that it works in any other case is just a fortunate set of circumstances as the logic to make sure it fits in the screen ends up putting it back.

I will need to add the locateInsideParent: true to the relevant part of in kde-workspace.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117121/#review54355
-----------------------------------------------------------


On March 27, 2014, 5:34 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117121/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 5:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add property to determine if popups should be inside or outside the parentItem
> 
> For some cases of dialog we want to position within the parent item for
> example widget explorer. For popup applets on the desktop the dialog
> should appear outside of the parentItem.
> 
> Currently we try to determine it automatically from the window type of
> the parentItem. This worked fine for widget explorer and panels, but
> breaks for popup applets on the desktop.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.h 3804d18 
>   src/plasmaquick/dialog.cpp 77c0c8c 
> 
> Diff: https://git.reviewboard.kde.org/r/117121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140327/4ff94b46/attachment-0001.html>