Review Request 117058: plasma-nm CMake fixes
Alexander Richardson
arichardson.kde at googlemail.com
Thu Mar 27 16:02:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117058/
-----------------------------------------------------------
(Updated March 27, 2014, 4:02 p.m.)
Review request for Plasma.
Changes
-------
Wrong group, it's not for frameworks even though that's for the frameworks port of plasma-nm.
Repository: plasma-nm
Description
-------
Don't find frameworks that are not required for compilation
----------------------------------------------------------
Also search CMAKE_PREFIX_PATH for the pkgconfig files
This will be the default behaviour when requiring CMake >= 3.1
Diffs
-----
CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7
Diff: https://git.reviewboard.kde.org/r/117058/diff/
Testing
-------
Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path)
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140327/f033ea31/attachment.html>
More information about the Plasma-devel
mailing list