Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review54220
-----------------------------------------------------------


All looks sane.  Is this Qt4 or Qt5?  Because you've got a KUrl in the added code...

- Alex Merry


On March 26, 2014, 5:23 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 5:23 p.m.)
> 
> 
> Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
> Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> 
> Some more work needs to be done in the adaptor which I plan to do soon.
> 
> 
> Diffs
> -----
> 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2.cpp ff96618 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mediaplayer2player.cpp 7871efa 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.cpp d2d71d4 
>   shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
> 
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbusviewer, the properties and methods are working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140326/d39ec617/attachment.html>