Review Request 116024: Port IconItem to native QSGTexture

[David Edmundson]

> On March 21, 2014, 9:24 a.m., Marco Martin wrote:
> > what's the status of this?

It wasn't really a priority before the beta, so I moved away for a bit.

Code as far as I'm concerned is fine, but I'd like to modify this so that we switch back away from a fading node when we're not animating. Otherwise we're keeping two QSGTexture objects when we only need one. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/#review53630
-----------------------------------------------------------


On Feb. 27, 2014, 1:44 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116024/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 1:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Port IconItem to native QSGTexture including the animation.
> This will save constantly uploading a new texture to OpenGL throughout the animation.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4bc47bf 
>   src/declarativeimports/core/CMakeLists.txt 97e9283 
>   src/declarativeimports/core/fadingnode.cpp PRE-CREATION 
>   src/declarativeimports/core/fadingnode_p.h PRE-CREATION 
>   src/declarativeimports/core/iconitem.h 26ee410 
>   src/declarativeimports/core/iconitem.cpp fed2f9b 
> 
> Diff: https://git.reviewboard.kde.org/r/116024/diff/
> 
> 
> Testing
> -------
> 
> Test app: http://paste.kde.org/pl5pwdnel
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140324/923022e2/attachment.html>