Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116956/#review53930
-----------------------------------------------------------


what about just renaming the installed targets? I don't see a benefit in renaming the desktop files, etc. in the source dir. Otherwise we will have to rename again with kglobalaccel6

- Martin Gräßlin


On March 21, 2014, 5:35 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116956/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 5:35 p.m.)
> 
> 
> Review request for KDE Runtime, Plasma and Martin Gräßlin.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> kde-runtime will soon get an alpha release.  Because both KF5 and kdelibs4 applications should be able to be installed and run it should be co-installable with kde-runtime from KDE 4 times.  Starting at the top of the cmake file I've renamed kglobalaccel to see if it's sane to do so.
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 
>   kglobalaccel/CMakeLists.txt 8bc8bea 
>   kglobalaccel/kglobalaccel.desktop a61516e 
>   kglobalaccel/kglobalaccel.notifyrc 9e3ecd3 
>   kglobalaccel/kglobalaccel5.desktop PRE-CREATION 
>   kglobalaccel/kglobalaccel5.notifyrc PRE-CREATION 
>   kglobalaccel/main.cpp d788b64 
> 
> Diff: https://git.reviewboard.kde.org/r/116956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140324/6202bc99/attachment.html>