Review Request 116907: Implemented "Player" MPRIS spec adaptor

Ashish Madeti ashishmadeti at gmail.com
Thu Mar 20 14:23:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/
-----------------------------------------------------------

(Updated March 20, 2014, 7:53 p.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Adopted a better way of ensuring volume remains in bounds, as suggested by Emmanuel


Repository: plasma-mediacenter


Description
-------

Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

Some more work needs to be done in the adaptor which I plan to do soon.


Diffs (updated)
-----

  libs/mpris2/mediaplayer2.h e68bc5c 
  libs/mpris2/mediaplayer2.cpp ff96618 
  libs/mpris2/mediaplayer2player.h 203d681 
  libs/mpris2/mediaplayer2player.cpp 7871efa 
  libs/mpris2/mpris2.cpp a8ad3ef 
  shells/newshell/mainwindow.cpp d2d71d4 
  shells/newshell/package/contents/ui/mediacenter.qml bac33c2 

Diff: https://git.reviewboard.kde.org/r/116907/diff/


Testing
-------

Tested with qdbusviewer, the properties and methods are working fine.


Thanks,

Ashish Madeti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140320/535a3186/attachment.html>


More information about the Plasma-devel mailing list