Review Request 116907: Implemented "Player" MPRIS spec adaptor

[Ashish Madeti]

> On March 20, 2014, 11 a.m., Sujith Haridasan wrote:
> > Ashish can you explain why do we need session bus for every single adaptor? Just wanted to know what advantage would that make?

We need to register each adaptor on session bus separately (i.e in their respective constructors) because if we register all the adaptors at one go, say in the constructor of MPRIS class, we will not be able to handle the events in a particular adaptor from QML (as QML will create a separate instance which has not been registered on sessionBus).
Therefore, we use MPRIS adaptor only to register PMC as a service on session bus. Each adaptor registers itself as an object from its own constructor.
PS: If we find that some adaptor has no relation whatsoever with QML, then we can register it right from MPRIS class (as a future change).


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116907/#review53474
-----------------------------------------------------------


On March 19, 2014, 10:52 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116907/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 10:52 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implemented "Player" DBus adaptor of MPRIS specifications for Plasma Mediacenter.
> Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html
> 
> Some more work needs to be done in the adaptor which I plan to do soon.
> 
> 
> Diffs
> -----
> 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2.cpp ff96618 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mediaplayer2player.cpp 7871efa 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   shells/newshell/mainwindow.cpp d2d71d4 
>   shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
> 
> Diff: https://git.reviewboard.kde.org/r/116907/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbusviewer, the properties and methods are working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140320/c0a9fee3/attachment-0001.html>