Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

[Sujith Haridasan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116898/#review53430
-----------------------------------------------------------

Ship it!


Looks good to me :)

- Sujith Haridasan


On March 19, 2014, 12:49 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116898/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:49 p.m.)
> 
> 
> Review request for Plasma and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots.
> 
> 
> Diffs
> -----
> 
>   libs/mpris2/mediaplayer2.h e68bc5c 
>   libs/mpris2/mediaplayer2player.h 203d681 
>   libs/mpris2/mpris2.h 0df64f4 
>   libs/mpris2/mpris2.cpp a8ad3ef 
>   shells/newshell/main.cpp bab6915 
>   shells/newshell/mainwindow.cpp d2d71d4 
> 
> Diff: https://git.reviewboard.kde.org/r/116898/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140319/2f0d3cfb/attachment.html>