Review Request 116625: Oxygen as default font

[Sebastian Kügler]

> On March 19, 2014, 1:16 a.m., Commit Hook wrote:
> > This review has been submitted with commit c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master.
> 
> Hrvoje Senjan wrote:
>     i was under the impression that consensus was to go with (only) r116633.
>     at least kdeglobals injection *should not* be needed with frameworkintegration change. or am i missing something?
> 
> Sebastian Kügler wrote:
>     r116633 is not enough, since it only sets the face and size of the font, but not its rendering method. (The XftHint, basically.) We technically don't need to set the face and size here, I just did it for completeness sake, but we can't remove this bit entirely, since the rendering method would otherwise not be set, and the font rendering would be unknown.

(Just realized that I had written an explanation earlier, but hadn't hit "publish", I've done that now. Sorry for the confusion.)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116625/#review53378
-----------------------------------------------------------


On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116625/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 1:16 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Make Oxygen the default font
> 
> This has three portions: the fonts itself, installation of them including 
> fontconfig bits, and setting font defaults in kdeglobals.
> 
> Oxygen Font 0.4 Imported from oxygen-font repository.
> 
> The startkde portion contains the bits to write out a kdeglobals default 
> file if it doesn't exist with font settings applied. Usually, with install 
> prefix set to /usr, the installed oxygen font is found automatically by 
> fontconfig. If we're installed to a different prefix, we need to point 
> fontconfig at the font. We do that by linking it from either 
> XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is
> irrelevant for systems that install into /usr.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 
>   fonts/CMakeLists.txt PRE-CREATION 
>   fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION 
>   fonts/oxygen/GPL.txt PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION 
>   fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION 
>   fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION 
>   fonts/oxygen/README PRE-CREATION 
>   startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 
> 
> Diff: https://git.reviewboard.kde.org/r/116625/diff/
> 
> 
> Testing
> -------
> 
> Logged into session with clean config. Font settings are applied correctly throughout.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140319/25208c45/attachment.html>