Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
R.Harish Navnit
harishnavnit at gmail.com
Tue Mar 18 18:00:50 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
-----------------------------------------------------------
(Updated March 18, 2014, 6 p.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Changes
-------
used runtimeData.url instead of runtimeData.playing. Seems to solve the issue reported by Ashish Madeti.
Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug
Repository: plasma-mediacenter
Description
-------
Now the next and previous buttons do not work unless a media is playing.
Diffs (updated)
-----
shells/newshell/package/contents/ui/mediacenter.qml b6cb87c
Diff: https://git.reviewboard.kde.org/r/116874/diff/
Testing
-------
I've done the testing for this patch.
These are the steps that I followed.
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly.
Thanks,
R.Harish Navnit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140318/07c016db/attachment.html>
More information about the Plasma-devel
mailing list