Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

Àlex Fiestas afiestas at kde.org
Tue Mar 18 16:43:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116872/#review53341
-----------------------------------------------------------

Ship it!


Some more extra cmake-fu is needed to make it work perfect, but it is a good start.

- Àlex Fiestas


On March 18, 2014, 1:45 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116872/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 1:45 p.m.)
> 
> 
> Review request for kwin, Plasma, Àlex Fiestas, and Aleix Pol Gonzalez.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> [kwin] Adjust CMakeLists.txt to allow standalone built of KWin
> 
> Preparation step before splitting:
> * adds project(KWIN)
> * lists all KWin dependencies
> 
> KWin can be built standalone if cmake is run with:
> -DKWIN_BUILD_OXYGEN=OFF
> -DKWIN_BUILD_KAPPMENU=OFF
> 
> Oxygen because it needs liboxygen - for standalone clients/oxygen needs
> to be moved out of KWin.
> 
> KAppmenu because it includes the DBus xml file.
> 
> 
> Diffs
> -----
> 
>   kwin/CMakeLists.txt d3dcead729f924ae4ebce733e000d24c71bc19bd 
> 
> Diff: https://git.reviewboard.kde.org/r/116872/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140318/abb68c72/attachment.html>


More information about the Plasma-devel mailing list