Review Request 116869: Completely remove the legacy ksmserver shutdown effect

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116869/#review53325
-----------------------------------------------------------

Ship it!


Looks good.

- Àlex Fiestas


On March 18, 2014, 7:46 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116869/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 7:46 a.m.)
> 
> 
> Review request for kwin, Plasma, Àlex Fiestas, and Teo Mrnjavac.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Completely remove the legacy ksmserver shutdown effect
> 
> Painting was already disabled in the effect inside ksmserver, thus it
> was more or less dead code. Let's remove it completely.
> 
> This also allows to remove the "temporary" hack inside KWin's logout
> effect.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/logout/logout.cpp 599efcd2156800ec1d8bfa8fb99bb7b074628fdb 
>   ksmserver/tests/test.cpp b69bc6ee065bcafc671b7fd44a98f7e832d8b1bd 
>   ksmserver/shutdowndlg.h 9a33a046d1a634bedf3a7367ee16b60836771d9d 
>   ksmserver/shutdowndlg.cpp feeedbeb5ea4b80c79e8888d4105fed4784bc70c 
>   ksmserver/shutdown.cpp e193ef73b6e540db72b3133e148d4c248929362a 
> 
> Diff: https://git.reviewboard.kde.org/r/116869/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140318/6e35745c/attachment-0001.html>