Review Request 116796: Show brightness OSD only on user input

[Sebastian Kügler]

> On March 17, 2014, 10:19 p.m., Àlex Fiestas wrote:
> > I can't test it but it looks good.
> > 
> > I wonder, can this be put in powerdevil from 4.13?

The DBus interface of plasma-shell is new, so if it's in powerdevil, it will only work if plasma-shell is running, not plasma-desktop. If that's the case you want to specifically support, yes, it can be done. Up to you I'd say if it's a sensible idea.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116796/#review53271
-----------------------------------------------------------


On March 16, 2014, 9:20 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116796/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 9:20 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> As discussed at the Plasma sprint, we want to show the OSD only on user input as a way of feedback to the action the user just did.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 228645b 
> 
> Diff: https://git.reviewboard.kde.org/r/116796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140318/f789c0fd/attachment-0001.html>