Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116836/
-----------------------------------------------------------

(Updated March 17, 2014, 7:58 p.m.)


Review request for Plasma and Sebastian Kügler.


Changes
-------

Return 0 instead of undefined.
That also fixed some margin glitches I used to have with the previous patch, thus dropping the leftMargin/rightMargin changes. Simple :-)


Repository: kde-workspace


Description
-------

This patch expands the search results list to cover the entire height (or horizontal space in case of left/right panel) of the plasmoid since the tabbar is hidden and it looks weird to reserve space for something that isn't there at the moment.

It also animates the re-appearance of the tabbar. Disappearance/Opacity of the tabbar is not animated due to performance reasons (got heavy lagging).


Diffs (updated)
-----

  plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml bfb1d16 

Diff: https://git.reviewboard.kde.org/r/116836/diff/


Testing
-------

Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140317/6d319330/attachment-0001.html>