Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116836/#review53066
-----------------------------------------------------------


Overall, good idea. I just noticed this the other day that this was wrong. I'm pondering also to not show the tabbar, b/c I think it's still useful to switch tabs with open search results. Also, search doesn't clear right now (it should), so the tabbar being shown is a bit more apparent than it used to be.

Overall, almost good to go. Thanks for looking into this.



plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml
<https://git.reviewboard.kde.org/r/116836/#comment37378>

    This is going to raise a warning b/c you're assigning undefined to an int, no? Returning 0 here is fine and avoids that warning.
    
    Same for the height.



plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml
<https://git.reviewboard.kde.org/r/116836/#comment37379>

    Warning. :)


- Sebastian Kügler


On March 16, 2014, 3:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116836/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 3:54 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch expands the search results list to cover the entire height (or horizontal space in case of left/right panel) of the plasmoid since the tabbar is hidden and it looks weird to reserve space for something that isn't there at the moment.
> 
> It also animates the re-appearance of the tabbar. Disappearance/Opacity of the tabbar is not animated due to performance reasons (got heavy lagging).
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml bfb1d16 
> 
> Diff: https://git.reviewboard.kde.org/r/116836/diff/
> 
> 
> Testing
> -------
> 
> Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140316/5bce080f/attachment.html>