Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116800/#review53005
-----------------------------------------------------------

Ship it!


There's a whole bunch of unrelated changes in here, which makes this a bit messy to review. Please take that into account next time you submit a review.

Otherwise, I think it's a useful feature.


plasmoidviewer/main.cpp
<https://git.reviewboard.kde.org/r/116800/#comment37300>

    unrelated



plasmoidviewer/view.h
<https://git.reviewboard.kde.org/r/116800/#comment37297>

    unrelated change.



plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/116800/#comment37296>

    Please use QProcess here, KProcess is kind-of-deprecated and doesn't add much over current QProcess.



plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/116800/#comment37302>

    These two could be collated into one const static, not a big issue, but looks a bit cleaner and is slightly more performant.


- Sebastian Kügler


On March 14, 2014, 3:59 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116800/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> The appletPath contains the path of the applet, if the user
> doesn't give a path then the refresh button of the plasmoidviewer will
> be hidden because we need the plasmoid path in order to execute
> `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically
> so the user can refresh the plasmoid without having to install the plasmoid manually.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/main.cpp e8e9b98 
>   plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 742f1d1 
>   plasmoidviewer/view.h d997f15 
>   plasmoidviewer/view.cpp 76fd542 
> 
> Diff: https://git.reviewboard.kde.org/r/116800/diff/
> 
> 
> Testing
> -------
> 
> 1. paths like ~/kf5/foo/plasmoid work
> 2. the plasmoid is being loaded even without the --appletPath
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140315/6538e874/attachment.html>