Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

[Shantanu Tushar]

> On March 15, 2014, 2:38 p.m., Sinny Kumari wrote:
> > shells/newshell/package/contents/ui/mediacenter.qml, line 366
> > <https://git.reviewboard.kde.org/r/116802/diff/1/?file=254061#file254061line366>
> >
> >     Instead of pushing playlist and popping it back, its better to not push it. Just create the playlist using getPlaylist() and don't show it.
> 
> Ashish Madeti wrote:
>     I already tried it. When I did it without pushing and popping i.e just calling getPlaylist(), I got some wierd object in left top corner of PMC when I return to the welcome screen (Just after the media player page shows up). It hangs there until I open Playlists page. I couldn't figure out what it was. Please check it.

I think thats what she meant by not showing it. Just say getPlaylist().visible = false;


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116802/#review52976
-----------------------------------------------------------


On March 14, 2014, 6:01 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116802/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 6:01 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Bugs: 331919
>     http://bugs.kde.org/show_bug.cgi?id=331919
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> When a media was played from a folder using "Open With" or is passed as an argument to PMC, playlist was shown instead of the media.
> This behavior is fixed in this patch.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 714e561 
> 
> Diff: https://git.reviewboard.kde.org/r/116802/diff/
> 
> 
> Testing
> -------
> 
> Tested with both "open with" and command line arguments.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140315/2f11764b/attachment-0001.html>