Review Request 116744: Play All Button in Plasma Media Center

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116744/#review52969
-----------------------------------------------------------


I think you can use a simpler logic described below,


browsingbackends/localfiles/localfilesabstractbackend.cpp
<https://git.reviewboard.kde.org/r/116744/#comment37278>

    Instead of so much effort here, in handleButtonClick() you can just count the number of existing media in the playlist and then use play(n), passing the index of the first media after adding the new items.


- Shantanu Tushar


On March 15, 2014, 5:20 a.m., Atul Dubey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116744/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Bugs: 331040
>     http://bugs.kde.org/show_bug.cgi?id=331040
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Tried to fix the Play All button... Now it plays the first track of the album that is added... 
> 
> Earlier, it was just getting populated in the playlist and the sog wasn't playing...
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 
> 
> Diff: https://git.reviewboard.kde.org/r/116744/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Atul Dubey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140315/5b973cc4/attachment-0001.html>