Review Request 116714: Use CMake config file to find dbusmenu-qt5

[Aurélien Gâteau]

> On March 11, 2014, 5:24 p.m., Aleix Pol Gonzalez wrote:
> > plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt, line 4
> > <https://git.reviewboard.kde.org/r/116714/diff/1/?file=253297#file253297line4>
> >
> >     Can't we make the target to export the include directories as well?

I plan to do that, but needs a merge-request on Launchpad, which can be slow. So I want to get rid of the find module as a first step.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116714/#review52657
-----------------------------------------------------------


On March 11, 2014, 3:12 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116714/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 3:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> dbusmenu-qt now provides a dbusmenu-qt5-config.cmake, so it is no longer necessary to ship a CMake find module for it. The same change has already been applied to the knotifications repository.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt dfbc4be 
>   plasma/generic/dataengines/CMakeLists.txt 187c24f 
>   appmenu/CMakeLists.txt 7e166e7 
>   cmake/modules/FindDBusMenuQt5.cmake 7d43489 
>   CMakeLists.txt 271e7d5 
> 
> Diff: https://git.reviewboard.kde.org/r/116714/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt kde-workspace, dbusmenu-qt5 is found.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140312/6bc70e86/attachment.html>